Skip to content

Add an abstract json layout to make it's easier to change json library #16528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 24, 2021
Merged

Add an abstract json layout to make it's easier to change json library #16528

merged 6 commits into from
Jul 24, 2021

Conversation

lunny
Copy link
Member

@lunny lunny commented Jul 24, 2021

As title

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Jul 24, 2021
@lunny lunny added this to the 1.16.0 milestone Jul 24, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jul 24, 2021 •
edited
Loading

Codecov Report

Merging #16528 (cb0ed3c) into main (1ce4fb2) will decrease coverage by 0.04%.
The diff coverage is 20.70%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #16528      +/-   ##
==========================================
- Coverage   45.48%   45.43%   -0.05%     
==========================================
  Files         718      720       +2     
  Lines       84317    84397      +80     
==========================================
- Hits        38350    38345       -5     
- Misses      39801    39878      +77     
- Partials     6166     6174       +8
Impacted Files Coverage Δ
cmd/dump.go 0.91% <ø> (+<0.01%) ⬆️
cmd/serv.go 2.53% <ø> (+0.01%) ⬆️
models/issue_comment.go 52.58% <ø> (-0.14%) ⬇️
models/login_source.go 34.52% <ø> (+0.01%) ⬆️
models/repo_unit.go 87.34% <ø> (-0.76%) ⬇️
models/task.go 38.40% <ø> (-0.67%) ⬇️
models/webhook.go 71.39% <ø> (-0.31%) ⬇️
modules/cache/cache_twoqueue.go 1.86% <ø> (+0.01%) ⬆️
modules/context/context.go 61.46% <ø> (-0.10%) ⬇️
modules/eventsource/event.go 24.61% <ø> (+0.37%) ⬆️
... and 75 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 342f338...cb0ed3c. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 24, 2021
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 24, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 24, 2021
@techknowlogick
Copy link
Member

@lunny please resolve conflicts

@zeripath
Copy link
Contributor

ah sorry for that @lunny

@lunny
Copy link
Member Author

lunny commented Jul 24, 2021

ah sorry for that @lunny

Never mind. It's easy to resolve the conflicts. Already done!

@6543 6543 merged commit 9f31f3a into go-gitea:main Jul 24, 2021
@lunny lunny deleted the lunny/json branch July 24, 2021 16:07
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 10, 2021
@lunny @AbdulrhmnGhanem
Add an abstract json layout to make it's easier to change json library (
4c52d6d 
go-gitea#16528)

* Add an abstract json layout to make it's easier to change json library

* Fix import

* Fix import sequence

* Fix blank lines

* Fix blank lines
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

@6543 6543 6543 approved these changes

+1 more reviewer

@zeripath zeripath zeripath approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.16.0
Development

Successfully merging this pull request may close these issues.
6 participants
@lunny @codecov-commenter @techknowlogick @zeripath @6543 @GiteaBot